This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Fixing invalid name for metrics component #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzew
commented
Nov 14, 2019
| - name: METRICS_DOMAIN | ||
| value: knative.dev/operator-operator | ||
| value: knative.dev/eventing-operator |
There was a problem hiding this comment.
changed to eventing-operator sicne that makes more sense ...
matzew
commented
Nov 14, 2019
config/operator.yaml
Outdated
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: metadata.name | ||
| value: "knative-serving-operator" |
There was a problem hiding this comment.
aligned the OPERATOR_NAME with how it is done for serving-operator ....
There was a problem hiding this comment.
Shouldn't it be knative-eventing-operator?
There was a problem hiding this comment.
@houshengbo thanks - I just corrected that !
…gs on the deployment yaml
matzew
force-pushed
the
fix_invalid_metrics_and_add_config
branch
from
6c70447
to
92f4dd4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and updating metrics settings on the deployment yaml