Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 types for ContainerSource #4257

Merged
merged 1 commit into from
Oct 9, 2020
Merged

v1 types for ContainerSource #4257

merged 1 commit into from
Oct 9, 2020

Conversation

eclipselu
Copy link
Contributor

@eclipselu eclipselu commented Oct 8, 2020

Part of #4175

Proposed Changes

  • Add ContainerSources v1 types
  • Gererated client code via ./hack/update-codegen.sh

Release Note

Move ContainerSource to v1 API. 

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2020
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 8, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1/container_defaults.go Do not exist 100.0%
pkg/apis/sources/v1/container_lifecycle.go Do not exist 89.7%
pkg/apis/sources/v1/container_types.go Do not exist 66.7%
pkg/apis/sources/v1/container_validation.go Do not exist 88.2%

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #4257 into master will increase coverage by 0.02%.
The diff coverage is 83.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4257      +/-   ##
==========================================
+ Coverage   80.22%   80.25%   +0.02%     
==========================================
  Files         283      287       +4     
  Lines        7819     7881      +62     
==========================================
+ Hits         6273     6325      +52     
- Misses       1164     1173       +9     
- Partials      382      383       +1     
Impacted Files Coverage Δ
pkg/apis/sources/v1/container_types.go 66.66% <66.66%> (ø)
pkg/apis/sources/v1/container_lifecycle.go 81.81% <81.81%> (ø)
pkg/apis/sources/v1/container_validation.go 82.35% <82.35%> (ø)
pkg/apis/sources/v1/container_defaults.go 100.00% <100.00%> (ø)
pkg/apis/sources/v1/register.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce2b4e1...0408cea. Read the comment docs.

@zhongduo
Copy link
Contributor

zhongduo commented Oct 8, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@eclipselu
Copy link
Contributor Author

/assign @vaikas

@eclipselu
Copy link
Contributor Author

/assign @Harwayne

@eclipselu
Copy link
Contributor Author

/unassign @vaikas

Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need container_conversion.go and container_conversion_test.go as well?

@Harwayne
Copy link
Contributor

Harwayne commented Oct 8, 2020

Do we need container_conversion.go and container_conversion_test.go as well?

These will be added at the same time as the conversion logic is added to/from v1 in the other versions.

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eclipselu, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@eclipselu
Copy link
Contributor Author

/test pull-knative-eventing-integration-tests

@grantr
Copy link
Contributor

grantr commented Oct 8, 2020

@eclipselu can you add a release note in the release-notes block describing the new feature?

@eclipselu
Copy link
Contributor Author

@eclipselu can you add a release note in the release-notes block describing the new feature?

@grantr thanks! Do I need to add this now? Since there will be more PRs incoming for this feature.

@eclipselu
Copy link
Contributor Author

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
@grantr
Copy link
Contributor

grantr commented Oct 8, 2020

@eclipselu it can be in any PR, so if you're planning more PRs for this feature, you can put the notes in a later one.

(Also, no need to hold for release notes - they can be edited in after the PR is merged)

@eclipselu
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:

test/e2e.TestBrokerRedelivery/InMemoryChannel-messaging.knative.dev/v1/sequence
test/e2e.TestBrokerRedelivery/InMemoryChannel-messaging.knative.dev/v1
test/e2e.TestBrokerRedelivery
.Test

@eclipselu
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants