-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 types for ContainerSource #4257
v1 types for ContainerSource #4257
Conversation
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## master #4257 +/- ##
==========================================
+ Coverage 80.22% 80.25% +0.02%
==========================================
Files 283 287 +4
Lines 7819 7881 +62
==========================================
+ Hits 6273 6325 +52
- Misses 1164 1173 +9
- Partials 382 383 +1
Continue to review full report at Codecov.
|
/lgtm |
/assign @vaikas |
/assign @Harwayne |
/unassign @vaikas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need container_conversion.go
and container_conversion_test.go
as well?
These will be added at the same time as the conversion logic is added to/from v1 in the other versions. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eclipselu, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-eventing-integration-tests |
@eclipselu can you add a release note in the |
@grantr thanks! Do I need to add this now? Since there will be more PRs incoming for this feature. |
/hold |
@eclipselu it can be in any PR, so if you're planning more PRs for this feature, you can put the notes in a later one. (Also, no need to hold for release notes - they can be edited in after the PR is merged) |
/unhold |
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-eventing-integration-tests:
|
/retest |
Part of #4175
Proposed Changes
./hack/update-codegen.sh
Release Note
Docs