Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pkg fuzzers from binary #4402

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 27, 2020

Signed-off-by: Ville Aikas vaikas@vmware.com

Address #4398

Proposed Changes

  • Grab the latest pkg that removes all the knative fuzzers from our binaries.

Release Note

- 🧽 Update or clean up current behavior
remove all knative fuzzers from our binaries.

Docs

Signed-off-by: Ville Aikas <vaikas@vmware.com>
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 27, 2020
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 27, 2020
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #4402 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4402   +/-   ##
=======================================
  Coverage   81.06%   81.06%           
=======================================
  Files         281      281           
  Lines        7964     7964           
=======================================
  Hits         6456     6456           
  Misses       1122     1122           
  Partials      386      386           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a54fd9...08c27b0. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit 83c12c4 into knative:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants