-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Tekton Resolvers for a standard on cluster build #1843
Conversation
@zroubalik: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zroubalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
- Coverage 62.50% 60.13% -2.38%
==========================================
Files 107 107
Lines 13800 13710 -90
==========================================
- Hits 8626 8244 -382
- Misses 4349 4628 +279
- Partials 825 838 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
58ec87b
to
9df018f
Compare
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
I have no idea why does |
/override "style / suggester / shell" |
@lance: Overrode contexts on behalf of lance: style / suggester / shell In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @zroubalik! I'd like to understand how we might use this in the openshift dev console as well. It's great that the tasks don't need to be explicitly installed now which will help scenarios like developer sandbox (where users don't have permission to install tasks). Currently dev sandbox does explicitly need to install both the tasks, AND the pipeline (here: https://github.com/openshift-knative/kn-plugin-func/blob/serverless-1.29.0/pkg/pipelines/resources/tekton/pipeline/dev-console/0.1/nodejs-pipeline.yaml). It would be great to eliminate the need for all of that to be installed, which it seems this PR does. We need to communicate with the dev console folks to ensure that we're all on the same page though. Thanks!
/override "style / suggester / shell" |
@zroubalik: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yeah, that's correct. You don't need to install Tasks, Pipeline etc manually. Does Dev Console solution run The only thing I don't like about this solution is that Tasks need to be fetched from git (and checking out https://github.com/knative/func.git can take some time). I think that we can workaround this by moving tasks to a separate repo (thus a smaller one) or to Tekton Hub, which I prefer. Btw Tekton PAC resolvers (a different technology) can fetch tasks directly from url, which is faster than pulling whole repo... func/pkg/pipelines/tekton/templates.go Lines 33 to 72 in b795fbe
|
/override "style / suggester / shell" |
@lance: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "style / suggester / github_actions" |
@lance: Overrode contexts on behalf of lance: style / suggester / github_actions, style / suggester / yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override unit-tests_func_main |
@lance: Overrode contexts on behalf of lance: unit-tests_func_main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LOL I was trying to override everything, thinking prow was still balking on stuff - but the problem was simply that it didn't have the lgtm |
@zroubalik does this work on Red Hat Sandbox? |
Changes
.tekton
directory in filespipeline-pac.yaml
andpipeline-run-pac.yaml
(added the-pac
suffix to distingush them from standard onesI have changed the way how Pipeline and PipelineRun resources are created - not using go client anymore, but using Manifestival to apply YAML resources - this simplifies templating and follows the pattern used for PAC builds.
Another benefit is, that users don't have preinstall Tasks anymore, they should be resolved by Tekton.
The workflow is following:
func deploy --remote
pipeline.yaml
and/orpipeline-run.yaml
in the.tekton
directory in the function project, we use the resources defined there to create the Pipeline and/or PipelineRunAbility to save the pipelines to the
.tekton
directory is not implemented yet, it will be in the follow up PR.Relates #620