Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OCI content created by "host" builder on Windows #1871

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: OCI content created by "host" builder on Windows #1871

merged 1 commit into from
Jul 18, 2023
+91 −6

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jul 13, 2023 •
edited
Loading

Changes

  • 🐛 Fix OCI generation by "host builder" on Windows.

@knative-prow
Copy link

knative-prow bot commented Jul 13, 2023

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Jul 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 13, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 13, 2023
@matejvasek matejvasek requested review from lkingland and removed request for maximilien and vyasgun July 13, 2023 19:05
@codecov
Copy link

codecov bot commented Jul 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.93 🎉

Comparison is base (ab5bbe1) 61.92% compared to head (a0bda5e) 62.85%.

❗ Current head a0bda5e differs from pull request most recent head b4023ea. Consider uploading reports for the commit b4023ea to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   61.92%   62.85%   +0.93%     
==========================================
  Files         107      107              
  Lines       13727    13729       +2     
==========================================
+ Hits         8501     8630     +129     
+ Misses       4383     4231     -152     
- Partials      843      868      +25
Flag Coverage Δ
e2e-test 35.57% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 30.62% <0.00%> (-0.03%) ⬇️
e2e-test-oncluster-runtime 25.63% <0.00%> (?)
e2e-test-runtime-go 25.98% <0.00%> (?)
e2e-test-runtime-quarkus 27.10% <0.00%> (?)
e2e-test-runtime-springboot 26.12% <0.00%> (?)
e2e-test-runtime-typescript 27.10% <0.00%> (?)
integration-tests 51.48% <100.00%> (+2.14%) ⬆️
unit-tests-macos-latest 49.27% <100.00%> (+0.03%) ⬆️
unit-tests-ubuntu-latest 50.06% <100.00%> (+<0.01%) ⬆️
unit-tests-windows-latest 49.28% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/oci/containerize.go 60.74% <100.00%> (ø)
pkg/oci/containerize_go.go 72.18% <100.00%> (+0.37%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 14, 2023
@matejvasek
fix: OCI content creation by "host" builder on Win
b4023ea 
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 14, 2023
@matejvasek matejvasek changed the title test: OCI content created by "host" builder fix: OCI content created by "host" builder on Windows\ Jul 14, 2023
@matejvasek matejvasek changed the title fix: OCI content created by "host" builder on Windows\ fix: OCI content created by "host" builder on Windows Jul 14, 2023
@matejvasek matejvasek marked this pull request as ready for review July 14, 2023 17:35
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2023
@matejvasek
Copy link
Contributor Author

PTAL @lkingland

@matejvasek matejvasek requested review from lance and jrangelramos and removed request for dsimansk and navidshaikh July 14, 2023 17:36
@matejvasek
Copy link
Contributor Author

/retest

matejvasek
matejvasek commented Jul 14, 2023
View reviewed changes
pkg/oci/builder_test.go
{Path: "/func/go.mod"},
{Path: "/func/handle.go"},
{Path: "/func/handle_test.go"},
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkingland why are the sources in the image? Shouldn't be there only executable and certificates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third layer is the data layer (for example, a repository which is a static HTTP site and a .go function which serves the files on request). The goal here was to use a .funcignore pre-populated with *.go when that feature is available. I will open a separate issue for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkingland I am afraid that if you add *.gos to .funcignore then the source will be also ignored by builders -- it won't compile application at all.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, depending on how we interpret the .funcignore per builder

I opened a discussion

@matejvasek
Copy link
Contributor Author

PTAL @lkingland

lkingland
lkingland approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

/retest

@matejvasek
Copy link
Contributor Author

/test unit-tests

1 similar comment
@matejvasek
Copy link
Contributor Author

/test unit-tests

@matejvasek
Copy link
Contributor Author

Why the hell is unit-tests_func_main failing?

@matejvasek
Copy link
Contributor Author

/test unit-tests

@matejvasek
Copy link
Contributor Author

@lance please override the error.

@lance
Copy link
Member

lance commented Jul 18, 2023

/override unit-tests_func_main

@knative-prow
Copy link

knative-prow bot commented Jul 18, 2023

@lance: Overrode contexts on behalf of lance: unit-tests_func_main

In response to this:

/override unit-tests_func_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit a9e5281 into knative:main Jul 18, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland approved these changes

@lance lance Awaiting requested review from lance

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

Assignees

@lkingland lkingland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejvasek @lance @lkingland