Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix s2i on cluster RT tests #2015

Merged
merged 3 commits into from
Oct 12, 2023
+4 −1
Merged

fix s2i on cluster RT tests #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da93f09
chore: use smaller s2i nodejs builder
matejvasek Oct 11, 2023
4811c85
test: skip python s2i on cluster build test on GH
matejvasek Oct 11, 2023
312433a
fixup: do check at correct place
matejvasek Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/builders/s2i/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
// DefaultName when no WithName option is provided to NewBuilder
const DefaultName = builders.S2I

var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16"
var DefaultNodeBuilder = "registry.access.redhat.com/ubi8/nodejs-16-minimal"
var DefaultQuarkusBuilder = "registry.access.redhat.com/ubi8/openjdk-17"
var DefaultPythonBuilder = "registry.access.redhat.com/ubi8/python-39"

Expand Down
3 changes: 3 additions & 0 deletions test/oncluster/scenario_runtime_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ func TestRuntime(t *testing.T) {
for _, builder := range runtimeSupportMap[lang] {
if targetBuilder == "" || builder == targetBuilder {
t.Run(fmt.Sprintf("%v_%v_test", lang, builder), func(t *testing.T) {
if lang == "python" && os.Getenv("GITHUB_ACTIONS") == "true" {
t.Skip("skipping python test in GH action because of space requirement")
}
runtimeImpl(t, lang, builder)
})
}
Expand Down
Loading