Add limit to number of manifests

[AdamKorcz]

Changes

A malicious image can include a high number of manifests and which makes the loop time controllable by an attacker. This can result in a DoS of func through an endless-data attack vector.

This PR sets a limit that is far more than a legitimate image would require, but that would still be fast to loop though.

/kind bug

Fixes #

Release Note

Docs

[knative-prow]

Welcome @AdamKorcz! It looks like this is your first PR to knative/func 🎉

[knative-prow]

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lkingland]

/ok-to-test

[lkingland]

Thanks for the contribution @AdamKorcz

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamKorcz, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cd0bc6a) 58.39% compared to head (796b298) 64.42%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2055      +/-   ##
==========================================
+ Coverage   58.39%   64.42%   +6.03%     
==========================================
  Files         106      106              
  Lines       13693    13696       +3     
==========================================
+ Hits         7996     8824     +828     
+ Misses       4905     3985     -920     
- Partials      792      887      +95     

Flag	Coverage Δ
e2e-test	36.45% <0.00%> (-0.01%)	⬇️
e2e-test-oncluster-runtime	26.96% <0.00%> (?)
e2e-test-runtime-go	25.58% <0.00%> (?)
e2e-test-runtime-node	26.50% <0.00%> (?)
e2e-test-runtime-python	26.59% <0.00%> (?)
e2e-test-runtime-quarkus	26.71% <0.00%> (?)
e2e-test-runtime-rust	25.58% <0.00%> (?)
e2e-test-runtime-springboot	25.72% <0.00%> (?)
e2e-test-runtime-typescript	26.71% <0.00%> (?)
integration-tests	51.91% <0.00%> (?)
unit-tests-macos-latest	48.77% <0.00%> (-0.02%)	⬇️
unit-tests-ubuntu-latest	49.51% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/docker/platform.go	50.00% <0.00%> (-3.34%)	⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.