Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log if image is referenced by tag #2090

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Nov 20, 2023

Changes

Adds a logging statement if the image is referenced by tag to inform the user of the risk.

/kind enhancement

Release Note

Log if image is referenced by tag in s2i builder.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2023
Copy link

knative-prow bot commented Nov 20, 2023

Hi @AdamKorcz. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (284da86) 63.87% compared to head (5993e61) 64.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
+ Coverage   63.87%   64.84%   +0.97%     
==========================================
  Files         108      108              
  Lines       13865    13868       +3     
==========================================
+ Hits         8856     8993     +137     
+ Misses       4140     3982     -158     
- Partials      869      893      +24     
Flag Coverage Δ
e2e-test 36.66% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 30.55% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster-runtime 26.82% <0.00%> (?)
e2e-test-runtime-go 25.55% <0.00%> (?)
e2e-test-runtime-node 26.56% <0.00%> (?)
e2e-test-runtime-python 26.56% <0.00%> (?)
e2e-test-runtime-quarkus 26.68% <0.00%> (?)
e2e-test-runtime-rust 25.57% <0.00%> (?)
e2e-test-runtime-springboot 25.70% <0.00%> (?)
e2e-test-runtime-typescript 26.68% <0.00%> (?)
integration-tests 51.81% <100.00%> (+2.01%) ⬆️
unit-tests-macos-latest 48.76% <100.00%> (+0.03%) ⬆️
unit-tests-ubuntu-latest ?
unit-tests-windows-latest 48.81% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek requested review from jrangelramos and lkingland and removed request for dsimansk and nainaz November 21, 2023 18:17
AdamKorcz and others added 2 commits November 29, 2023 16:02
Signed-off-by: AdamKorcz <adam@adalogics.com>
Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor

PTAL @jrangelramos @lkingland @gauron99

@matejvasek
Copy link
Contributor

@ReToCode @lance please override the Check Source (ubuntu-latest) error.

@ReToCode
Copy link
Member

/override "Check Source (ubuntu-latest)"

Copy link

knative-prow bot commented Nov 29, 2023

@ReToCode: Overrode contexts on behalf of ReToCode: Check Source (ubuntu-latest)

In response to this:

/override "Check Source (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2023
@upodroid
Copy link
Member

/retest

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2023
Copy link

knative-prow bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamKorcz, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2023
@knative-prow knative-prow bot merged commit 7ebf92d into knative:main Nov 29, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants