Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PaC build #2341

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: PaC build #2341

merged 1 commit into from
Jun 11, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 6, 2024

  • Fixed the issues where PaC configuration failed under unprivileged user.
fix: Pipelines as Code setup failure under unprivileged user

@knative-prow knative-prow bot requested review from maximilien and nainaz June 6, 2024 17:26
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 62.72%. Comparing base (ef2edc5) to head (b0bd9ce).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/pipelines/tekton/pac/pac.go 0.00% 7 Missing ⚠️
pkg/pipelines/tekton/pipelines_pac_provider.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
+ Coverage   60.22%   62.72%   +2.49%     
==========================================
  Files         128      126       -2     
  Lines       14890    11526    -3364     
==========================================
- Hits         8968     7230    -1738     
+ Misses       5003     3377    -1626     
  Partials      919      919              
Flag Coverage Δ
e2e-test 37.99% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 31.22% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster-runtime 26.88% <0.00%> (?)
e2e-test-runtime-springboot 26.11% <0.00%> (?)
integration-tests ?
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Fixed detection of PaC controller URL for unprivileged users.
* Use fn.Deploy.Image before fn.Image since the fn.Image may not be
  populated.

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for maximilien and nainaz June 6, 2024 17:34
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
Copy link

knative-prow bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Contributor Author

The Integration Test (ubuntu-latest) test failed several times because of low disk space. I don't think it's related to this PR.

@dsimansk please override it

@dsimansk
Copy link
Contributor

/override Integration Test (ubuntu-latest)

Copy link

knative-prow bot commented Jun 11, 2024

@dsimansk: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • (ubuntu-latest)
  • Integration
  • Test

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Integration Test (ubuntu-latest)
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Integration Test (ubuntu-latest)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/override "Integration Test (ubuntu-latest)"

Copy link

knative-prow bot commented Jun 11, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: Integration Test (ubuntu-latest)

In response to this:

/override "Integration Test (ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit a898fe7 into knative:main Jun 11, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants