Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure in GHA caused by missing cargo bin #2440

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

matejvasek
Copy link
Contributor

It appears that the cargo in no longer part of GHA image at least for macOS.

Changes

/kind

Fixes #

Release Note


Docs


It appears that the cargo in no longer part of GHA image at least for macOS.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Copy link

knative-prow bot commented Jul 23, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

It appears that the cargo in no longer part of GHA image at least for macOS.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.41%. Comparing base (531af8f) to head (b09e974).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
- Coverage   65.19%   63.41%   -1.78%     
==========================================
  Files         129      130       +1     
  Lines       11934    11940       +6     
==========================================
- Hits         7780     7572     -208     
- Misses       3222     3434     +212     
- Partials      932      934       +2     
Flag Coverage Δ
e2e-test ?
e2e-test-oncluster 33.38% <ø> (+0.06%) ⬆️
e2e-test-oncluster-runtime 29.39% <ø> (?)
e2e-test-runtime-go 25.22% <ø> (?)
e2e-test-runtime-node 26.15% <ø> (?)
e2e-test-runtime-python 26.15% <ø> (?)
e2e-test-runtime-quarkus 26.25% <ø> (?)
e2e-test-runtime-rust 25.27% <ø> (?)
e2e-test-runtime-springboot 25.33% <ø> (?)
integration-tests 52.78% <ø> (+2.40%) ⬆️
unit-tests 50.94% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
Copy link

knative-prow bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

@matejvasek what's up with codecov coverage? flake?

@knative-prow knative-prow bot merged commit 7a75fec into knative:main Jul 23, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants