Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate client-pkg to client/pkg #2477

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Sep 4, 2024

No description provided.

Copy link

linux-foundation-easycla bot commented Sep 4, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 4, 2024
@gauron99 gauron99 requested review from lkingland and removed request for nainaz and vyasgun September 4, 2024 07:57
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2024
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.08%. Comparing base (799de30) to head (9a70f46).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2477      +/-   ##
==========================================
+ Coverage   61.54%   67.08%   +5.53%     
==========================================
  Files         129      129              
  Lines       15334    11928    -3406     
==========================================
- Hits         9438     8002    -1436     
+ Misses       4970     2964    -2006     
- Partials      926      962      +36     
Flag Coverage Δ
e2e-test 36.61% <ø> (ø)
e2e-test-oncluster 33.42% <ø> (-0.02%) ⬇️
e2e-test-oncluster-runtime 29.52% <ø> (?)
e2e-test-runtime-go 26.61% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 26.00% <ø> (?)
e2e-test-runtime-quarkus 26.10% <ø> (?)
e2e-test-runtime-rust 25.15% <ø> (?)
e2e-test-runtime-springboot 25.18% <ø> (?)
e2e-test-runtime-typescript 26.09% <ø> (?)
integration-tests 53.13% <ø> (+2.40%) ⬆️
unit-tests 51.30% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

just a nit: I would not group knative.dev/client with knative.dev/func.

@gauron99
Copy link
Contributor Author

gauron99 commented Sep 4, 2024

Do you want to group it with github & k8s or should i put it separately?

@matejvasek
Copy link
Contributor

Do you want to group it with github & k8s or should i put it separately?

Yes group it with github.

I think that right now we do following grouping:

  • Go stdlib
  • external deps
  • our own packages (knative.dev/func).

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
@cardil
Copy link
Contributor

cardil commented Sep 4, 2024

Looks good to me, but let maintainers approve.

@matejvasek
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link

knative-prow bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit a13056e into knative:main Sep 4, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants