Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary 'go get' commands #2524

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Sep 27, 2024

Changes

  • Remove unnecessary 'go get' commands

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Copy link

knative-prow bot commented Sep 27, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Sep 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (62ca4c7) to head (3e6b297).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
+ Coverage   61.43%   66.86%   +5.43%     
==========================================
  Files         130      130              
  Lines       15479    12035    -3444     
==========================================
- Hits         9509     8047    -1462     
+ Misses       5029     3012    -2017     
- Partials      941      976      +35     
Flag Coverage Δ
e2e-test 36.60% <50.00%> (+<0.01%) ⬆️
e2e-test-oncluster 33.33% <0.00%> (-0.04%) ⬇️
e2e-test-oncluster-runtime 29.69% <0.00%> (?)
e2e-test-runtime-go 26.59% <0.00%> (?)
e2e-test-runtime-node 25.98% <0.00%> (?)
e2e-test-runtime-python 25.98% <0.00%> (?)
e2e-test-runtime-quarkus 26.08% <0.00%> (?)
e2e-test-runtime-rust 25.13% <0.00%> (?)
e2e-test-runtime-springboot 25.16% <0.00%> (?)
e2e-test-runtime-typescript 26.07% <0.00%> (?)
integration-tests 53.08% <50.00%> (+2.37%) ⬆️
unit-tests 51.63% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

/test all

@matejvasek matejvasek changed the title [DNM] Remove unnecessary 'go get' commands Remove unnecessary 'go get' commands Sep 27, 2024
@matejvasek matejvasek marked this pull request as ready for review September 27, 2024 11:32
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for vyasgun September 27, 2024 11:33
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
Copy link

knative-prow bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d481289 into knative:main Sep 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants