Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value for REGISTRY param on func-s2i task #2530

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

jrangelramos
Copy link
Contributor

Changes

  • 🧹 Set default value for REGISTRY param on func-s2i task

/kind cleanup

@knative-prow knative-prow bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 2, 2024
@knative-prow knative-prow bot requested review from nainaz and vyasgun October 2, 2024 20:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (be3a8a0) to head (ed5f65c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
+ Coverage   61.43%   66.88%   +5.44%     
==========================================
  Files         130      130              
  Lines       15464    12036    -3428     
==========================================
- Hits         9501     8050    -1451     
+ Misses       5024     3011    -2013     
- Partials      939      975      +36     
Flag Coverage Δ
e2e-test 36.55% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 33.40% <100.00%> (-0.01%) ⬇️
e2e-test-oncluster-runtime 29.69% <100.00%> (?)
e2e-test-runtime-go 26.59% <0.00%> (?)
e2e-test-runtime-node 25.98% <0.00%> (?)
e2e-test-runtime-python 25.98% <0.00%> (?)
e2e-test-runtime-quarkus 26.08% <0.00%> (?)
e2e-test-runtime-rust 25.10% <0.00%> (?)
e2e-test-runtime-springboot 25.16% <0.00%> (?)
e2e-test-runtime-typescript 26.07% <0.00%> (?)
integration-tests 53.08% <100.00%> (+2.39%) ⬆️
unit-tests 51.65% <100.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2024
Copy link

knative-prow bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f336940 into knative:main Oct 3, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants