Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JS/TS template dependencies #2534

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 7, 2024
@knative-prow knative-prow bot requested a review from vyasgun October 7, 2024 16:34
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.86%. Comparing base (35eb3a4) to head (e022324).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   60.63%   66.86%   +6.23%     
==========================================
  Files         130      130              
  Lines       15465    12036    -3429     
==========================================
- Hits         9377     8048    -1329     
+ Misses       5180     3012    -2168     
- Partials      908      976      +68     
Flag Coverage Δ
e2e-test 36.60% <ø> (+0.04%) ⬆️
e2e-test-oncluster 33.42% <ø> (?)
e2e-test-oncluster-runtime 29.69% <ø> (?)
e2e-test-runtime-go 26.59% <ø> (?)
e2e-test-runtime-node 25.98% <ø> (?)
e2e-test-runtime-python 25.98% <ø> (?)
e2e-test-runtime-quarkus 26.08% <ø> (?)
e2e-test-runtime-rust 25.12% <ø> (?)
e2e-test-runtime-springboot 25.16% <ø> (?)
e2e-test-runtime-typescript 26.07% <ø> (?)
integration-tests 53.09% <ø> (+2.38%) ⬆️
unit-tests 51.63% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Copy link
Contributor Author

PTAL @matzew @lkingland @gauron99

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
Copy link

knative-prow bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link
Contributor

gauron99 commented Oct 7, 2024

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@matejvasek
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@knative-prow knative-prow bot merged commit d7d688e into knative:main Oct 7, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants