-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix update-codegen.sh when run outside GOPATH #18
Conversation
606a1cb
to
5b00453
Compare
c78a907
to
5f13329
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Cynocracy The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5f13329
to
4ea8956
Compare
4ea8956
to
9c436c4
Compare
/assign @grantr |
As an answer to the question: why not simply update client-go? The latest version uses the OpenAPIv2 package instead of openapiv2, and updating client-go leads to a diamond dependency problem that can't be solved with replace directives because you can't alias two packages to the same module (OpenAPIv2, OpenAPIv3) -> (openapiv2, openapiv3) |
/assign @n3wscott as I hear you've played around in the area 😄 |
Can you confirm that the client gen produces code in the go mod file path? I was testing and was only able to change the package, but that package was always rooted in |
Can confirm, This code was generated using just ./hack/update-codegen.sh outside of GOPATH |
/lgtm |
9c436c4
to
47ce700
Compare
New changes are detected. LGTM label has been removed. |
@Cynocracy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Cynocracy: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Cynocracy can you please rebase? thanks |
Yup sorry about that, I have a bunch of these I should go back and clean up.
…On Sat, Aug 1, 2020 at 4:28 PM Nghia Tran ***@***.***> wrote:
@Cynocracy <https://github.com/Cynocracy> can you please rebase? thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAICPOUTMY53J7MO5QZ4VSDR6SQKXANCNFSM4OCMOQYA>
.
|
Actually, given that I found recently ko works 1:1 with go's semantics re:
build flags, I might just revert these. Sorry for the noise
…On Sat, Aug 1, 2020 at 5:15 PM Jonathan Donovan ***@***.***> wrote:
Yup sorry about that, I have a bunch of these I should go back and clean
up.
On Sat, Aug 1, 2020 at 4:28 PM Nghia Tran ***@***.***>
wrote:
> @Cynocracy <https://github.com/Cynocracy> can you please rebase? thanks
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#18 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAICPOUTMY53J7MO5QZ4VSDR6SQKXANCNFSM4OCMOQYA>
> .
>
|
Fix update-codegen.sh after modules migration by hacking generate-groups and generate-internal-groups.
Addresses knative/pkg#1287 if accepted will likely attempt an upstream into library.sh.