Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPAS native output support + example #16

Merged
merged 33 commits into from
Feb 5, 2024
Merged

MPAS native output support + example #16

merged 33 commits into from
Feb 5, 2024

Conversation

zmoon
Copy link
Collaborator

@zmoon zmoon commented Dec 1, 2023

  • unstructured grid support in contours and identify, assumed if only one spatial dimension
    • Using Delaunay triangulation on lat/lon grid points (or user-provided Triangulation) + Matplotlib tricontour
  • example with subset of native MPAS output, same time and location as the existing (regridded) MPAS example dataset
  • gdown support for downloading examples added as mentioned in gdown cached download for examples #9
  • some comparison to mpas-tools grid-to-triangles Triangulation
  • some doc updates

Note

Should add dask-core and gdown to the conda-forge recipe for this release.

probably temporary, may not really be the best idea

but otherwise get

  cannot pickle '_thread.lock' object

in the joblib parallel setup

normally don't use parallel for this anyway, since there are only
6 time steps and it is pretty fast in serial
since over 100 MB it hits the virus check page though
Also tried this longer command, which supposedly did it in the past

["wget", "--no-verbose", "--no-check-certificate", url, "-O", (HERE / fn).as_posix(), "-r", "-A", "'uc*'", "-e", "robots=off", "-nd"]

but didn't work now
plotting the data and seeing how the contouring could work
they are the same geo area and such, might as well
@knubez
Copy link
Owner

knubez commented Dec 13, 2023

Directory for sample MPAS native data:

/glade/derecho/scratch/knocasio/FROM_CHEYENNE/15km_MPAS_IFS_8sept_12utc_Thompson_MYNN/diag.2006-09-*.nc"

Directory of mesh:

/glade/derecho/scratch/knocasio/FROM_CHEYENNE/15km_MPAS_model_IFS/mpas_15mesh.nc

tams/data.py Outdated Show resolved Hide resolved
wget command for the large file that worked before doesn't anymore

there are apparently workarounds that work in 2024
https://medium.com/geekculture/wget-large-files-from-google-drive-336ba2e1c991

but gdown seems the safer way to go
and hide the output of the first (import) cell

so as not to see the

ERROR 1: PROJ: proj_create_from_database ... failed

message
note: had to use :func: or the functions stopped getting linked
with the addition of a :doc:

seems :ref: works fine without this modification, but then get
annoying anchor links that aren't needed
saw this warning in RTD:
tams/data.py:238: FutureWarning: The return type of `Dataset.dims` will be changed to return a set of dimension names in future, in order to be more consistent with `DataArray.dims`. To access a mapping from dimension names to lengths, please use `Dataset.sizes`.
@zmoon zmoon marked this pull request as ready for review February 4, 2024 05:17
and crossref the example

also str agg wasn't working I think,
but now it should

but really should type it properly
since single callable should be supported as well
Copy link
Owner

@knubez knubez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate all of the descriptive comments and how accessible it is now.

@zmoon zmoon merged commit 5abfb31 into main Feb 5, 2024
2 checks passed
@zmoon zmoon deleted the mpas-ug branch February 5, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants