-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove review trigger and group github-{BDW,H100,MI201} under github-AT2 #2320
Merged
lucbv
merged 1 commit into
kokkos:develop
from
e10harvey:remove_trigger_and_single_at2_workflow_upd
Aug 29, 2024
Merged
Remove review trigger and group github-{BDW,H100,MI201} under github-AT2 #2320
lucbv
merged 1 commit into
kokkos:develop
from
e10harvey:remove_trigger_and_single_at2_workflow_upd
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e10harvey
force-pushed
the
remove_trigger_and_single_at2_workflow_upd
branch
from
August 28, 2024 23:03
e1801c7
to
bdd81c2
Compare
lucbv
reviewed
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if I can re-trigger after a comment?
cwpearson
approved these changes
Aug 29, 2024
ndellingwood
pushed a commit
to ndellingwood/kokkos-kernels
that referenced
this pull request
Sep 5, 2024
ndellingwood
added a commit
that referenced
this pull request
Sep 12, 2024
* Restore size_t as default offset, in Tribits builds (#2313) If building KokkosKernels standalone, leave int as the default offset (this was the case since #2140). But if building KokkosKernels as a Trilinos/Tribits package, then make size_t the default offset because this is what the Tpetra stack currently uses. Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * Improve crs/bsr sorting performance (#2293) * CRS sorting improvements - Wrote bulk sort/permutation based sorting for CRS graph, matrix, and BSR matrix (bulk = one large sort of all the entries, using row-major dense index as keys) - This is more performant for imbalanced entries per row - If matrix dimensions are too large to do bulk sort, fall back to sorting within each row with a thread. * Add perf test for sort_crs_matrix * sort_crs: improve parallel labels * Work around kokkos issue 7036 * sort_crs: replace radix sort lambda with functor (Lambda segfaults with nvcc+openmp) --------- Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * SpAdd handle: delete sort_option getter/setter (#2296) SpAdd handle was originally a copy-paste of the spgemm handle way back in #122, and included get_sort_option() and set_sort_option() from spgemm. But these try to use the member bool sort_option, which doesn't exist. Somehow these functions never produced compile errors until someone tried to call them. * Improve GH action to produce release artifacts (#2312) * coo2csr: add parens to function calls (#2318) * Update changelog * Update master_history.txt * .github/workflows: Group jobs under common github-AT2 name (#2320) * Update master_history.txt --------- Signed-off-by: Brian Kelley <bmkelle@sandia.gov> Co-authored-by: brian-kelley <bmkelle@sandia.gov> Co-authored-by: Damien L-G <dalg24@gmail.com> Co-authored-by: Carl Pearson <cwpearson@users.noreply.github.com> Co-authored-by: Evan Harvey <57234914+e10harvey@users.noreply.github.com>
lucbv
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Set version number to 4.4.01 * [4.4.01] Patches to 4.4.01 (#2327) * Restore size_t as default offset, in Tribits builds (#2313) If building KokkosKernels standalone, leave int as the default offset (this was the case since #2140). But if building KokkosKernels as a Trilinos/Tribits package, then make size_t the default offset because this is what the Tpetra stack currently uses. Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * Improve crs/bsr sorting performance (#2293) * CRS sorting improvements - Wrote bulk sort/permutation based sorting for CRS graph, matrix, and BSR matrix (bulk = one large sort of all the entries, using row-major dense index as keys) - This is more performant for imbalanced entries per row - If matrix dimensions are too large to do bulk sort, fall back to sorting within each row with a thread. * Add perf test for sort_crs_matrix * sort_crs: improve parallel labels * Work around kokkos issue 7036 * sort_crs: replace radix sort lambda with functor (Lambda segfaults with nvcc+openmp) --------- Signed-off-by: Brian Kelley <bmkelle@sandia.gov> * SpAdd handle: delete sort_option getter/setter (#2296) SpAdd handle was originally a copy-paste of the spgemm handle way back in #122, and included get_sort_option() and set_sort_option() from spgemm. But these try to use the member bool sort_option, which doesn't exist. Somehow these functions never produced compile errors until someone tried to call them. * Improve GH action to produce release artifacts (#2312) * coo2csr: add parens to function calls (#2318) * Update changelog * Update master_history.txt * .github/workflows: Group jobs under common github-AT2 name (#2320) * Update master_history.txt --------- Signed-off-by: Brian Kelley <bmkelle@sandia.gov> Co-authored-by: brian-kelley <bmkelle@sandia.gov> Co-authored-by: Damien L-G <dalg24@gmail.com> Co-authored-by: Carl Pearson <cwpearson@users.noreply.github.com> Co-authored-by: Evan Harvey <57234914+e10harvey@users.noreply.github.com> * Update master_history.txt for 4.4.01 --------- Signed-off-by: Brian Kelley <bmkelle@sandia.gov> Co-authored-by: brian-kelley <bmkelle@sandia.gov> Co-authored-by: Damien L-G <dalg24@gmail.com> Co-authored-by: Carl Pearson <cwpearson@users.noreply.github.com> Co-authored-by: Evan Harvey <57234914+e10harvey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1-review
2-approve if everything looks good
3-scroll to bottom of PR with CI statuses
4-click details on one of the github-AT2 jobs
5-click re-run all jobs
Anyone on the approved team can do this. PRs authored by and with commits solely from approved team members will still auto-run without a reviewer.