Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional log checkpoint information #1070

Merged
merged 13 commits into from
Mar 6, 2023

Conversation

directionless
Copy link
Contributor

@directionless directionless commented Mar 4, 2023

In thinking about how to add more information to the checkpoint logs it felt like this needed to become a struct -- easier to hold some state, add a querier, and whatnot.

  1. Refactor to a checkpointer struct, moved the Run around a little
  2. Add a SetQuerier function
  3. When there is a querier, additional things are queried.

Fixes: #1061

@directionless directionless marked this pull request as ready for review March 5, 2023 01:14
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

pkg/log/checkpoint/queried.go Show resolved Hide resolved
@directionless directionless merged commit ea869a7 into kolide:main Mar 6, 2023
@directionless directionless deleted the seph/log-checkpoints branch March 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential improvements to the log checkpoint data
2 participants