Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tables for rhel and arch package managers #1275

Merged
merged 6 commits into from
Aug 4, 2023
Merged

Add tables for rhel and arch package managers #1275

merged 6 commits into from
Aug 4, 2023

Conversation

Micah-Kolide
Copy link
Contributor

No description provided.

directionless
directionless reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks pretty good

pkg/osquery/table/platform_tables_linux.go Show resolved Hide resolved
pkg/osquery/tables/execparsers/dnf/parser.go Outdated Show resolved Hide resolved
pkg/osquery/tables/execparsers/dnf/parser.go Outdated Show resolved Hide resolved
pkg/osquery/tables/execparsers/pacman/info/parser.go Show resolved Hide resolved
pkg/osquery/tables/execparsers/pacman/upgradeable/parser.go Outdated Show resolved Hide resolved
pkg/osquery/tables/execparsers/rpm/parser.go Show resolved Hide resolved
pkg/osquery/tables/execparsers/rpm/parser.go Show resolved Hide resolved
James-Pickett
James-Pickett reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, had mostly same comments as seph about using continue instead of if else statments.

@directionless
Copy link
Contributor

I'd take it!

@directionless directionless changed the title Add rhel and arch package manager exec parsers Add tables for rhel and arch package managers Aug 4, 2023
directionless
directionless approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm good with it.

@directionless directionless merged commit b4b2646 into main Aug 4, 2023
24 checks passed
@directionless directionless deleted the micah/add_arch_and_rhel_package_execparsers branch August 4, 2023 13:18
@directionless directionless mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@James-Pickett James-Pickett James-Pickett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Micah-Kolide @directionless @James-Pickett