Add rfm history to allowed falconctl options #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
approved these changes
Feb 6, 2024
James-Pickett
approved these changes
Feb 6, 2024
zackattack01
approved these changes
Feb 6, 2024
|
|
James-Pickett
pushed a commit
to James-Pickett/launcher
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We learned here that there's a third mode (aside kernel and reduced functionality) that we do not currently consider. We can determine this third mode, user mode, by looking at the rfm history.
This PR adds
--rfm-historyto the allowedOptions for falconctl, which looks like this: