Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the kolide_spotlight table with a longer timeout #1587

Merged
merged 6 commits into from
Feb 8, 2024
Merged

Update the kolide_spotlight table with a longer timeout #1587

merged 6 commits into from
Feb 8, 2024

Conversation

directionless
Copy link
Contributor

@directionless directionless commented Feb 8, 2024 •
edited
Loading

Relates to https://github.com/kolide/k2/issues/9493

To address an mdfind issue, this PR does a couple of things:

  1. It ups the mdfind exec timeout. I'm a little wary here, but we see cases where 60s time out
  2. It moves the kolide_spotlight table to using the tablehelpers.Exec.
  3. TODO: improve the exec helper's timing info

@directionless directionless marked this pull request as ready for review February 8, 2024 14:20
James-Pickett
James-Pickett previously approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@directionless @RebeccaMahany
Update pkg/osquery/interactive/interactive_test.go
a37c1ef 
Co-authored-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com>
@directionless directionless added this pull request to the merge queue Feb 8, 2024
Merged via the queue into kolide:main with commit 05ea36a Feb 8, 2024
28 checks passed
@directionless directionless deleted the seph/timeouts branch February 8, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

@James-Pickett James-Pickett James-Pickett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@directionless @RebeccaMahany @James-Pickett