Remove autoloaded extensions #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
approved these changes
Feb 14, 2024
directionless
approved these changes
Feb 15, 2024
| @@ -317,10 +317,10 @@ func getPossibleUpdates(ctx context.Context, updateDir, binaryName string) ([]st | |||
| return possibleUpdates, nil | |||
| } | |||
|
|
|||
| // FindBaseDir takes a binary path, that may or may not include the | |||
| // findBaseDir takes a binary path, that may or may not include the | |||
There was a problem hiding this comment.
Do we still need this, and anything else in the FindNewest?
There was a problem hiding this comment.
Yeah, we fall back to the legacy autoupdate library currently if there's nothing in the new library. We can definitely get rid of that at some point, but I wasn't in a rush to rip that part out as quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't expect to find autoloaded extensions based on the current executable anymore, because the current executable may live in the new updates directory outside of the install (bin) directory. We don't use this flag and we don't imagine that it has widespread use elsewhere either, so we're opting to remove it.