Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger TUF when running from build directory #1607

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

directionless
Copy link
Contributor

The old updater had the side effect of not triggering the update check when running from a build dir. I found that quite convenient, as I'm often running launcher in a development cycle. This recreates that behavior with a somewhat klunky path check.

If y'all think it will have some unknown impact around CI or testing, speak up...

@RebeccaMahany
Copy link
Contributor

I don't think there will be a negative impact to doing this, so if you want it, sure.

I am personally not in favor of adding this -- I don't think we need to add additional complexity to an already complicated system when there are already two other workarounds that meet this need during development (LAUNCHER_SKIP_UPDATES and localdev_path).

@directionless
Copy link
Contributor Author

I'm willing to hold while we figure out what we want, and how to cleanly handle it.

Mostly, I want to be able to do things like make && ./build/launcher and get the build I just made. And I see the other things are serving different purposes. LAUNCHER_SKIP_UPDATES was designed as an internal safety to prevent forkbombs, localdev_path is for doing local TUF development.

@RebeccaMahany
Copy link
Contributor

RebeccaMahany commented Feb 15, 2024

localdev_path isn't just for local TUF development but for all local development purposes -- e.g. I set localdev_path /path/to/my/launcher/build/darwin.universal/Kolide.app/Contents/MacOS/launcher in my launcher.flags file and unload/build/reload for all local development. (It was meant to be a replacement for the workflow where you could create a new timestamp dir in /usr/local/kolide-k2/bin/launcher-updates and copy a build there to run your desired launcher build.)

@directionless
Copy link
Contributor Author

directionless commented Feb 15, 2024

localdev_path isn't just for local TUF development but for all local development purposes

If we believe that, then we should make it part of the development environment. I'm not totally sure how we'd want to do that. And I kinda feel mixed. I like things to just DTRT when possible

@RebeccaMahany
Copy link
Contributor

@directionless I think the discussion is getting long enough that we should move it to slack, or if you want to table it for our next team meeting -- I would like to know what "make it a part of the development environment" entails for you (plus I would also like to know if localdev_path has been adequate/not painful for James and Zack, or if they also want an alternative like this)

@directionless
Copy link
Contributor Author

We discussed this today, and I think concluded we should merge it.

@directionless directionless added this pull request to the merge queue Feb 29, 2024
Merged via the queue into kolide:main with commit 3a88d8d Feb 29, 2024
29 checks passed
@directionless directionless deleted the seph/skip-updates branch February 29, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants