Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osquery restart history to checkups #1633

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

zackattack01
Copy link
Contributor

These changes add a checkup to include the osquery restart history instances for doctor + flare.

This should close #1071

RebeccaMahany
RebeccaMahany previously approved these changes Mar 1, 2024
directionless
directionless previously approved these changes Mar 1, 2024

restartHistory, err := history.GetHistory()
if err != nil && errors.Is(err, history.NoInstancesError{}) {
orc.status = Passing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider whether this is Passing or Informational.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Informational does seem more appropriate here I will update

@zackattack01 zackattack01 added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 0c783a3 Mar 1, 2024
31 checks passed
@zackattack01 zackattack01 deleted the zack/osquery_restart_checkup branch March 1, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need a checkup about osquery restart information
3 participants