Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to logging and flares #1667

Merged
merged 8 commits into from
Apr 4, 2024
Merged

Small improvements to logging and flares #1667

merged 8 commits into from
Apr 4, 2024

Conversation

directionless
Copy link
Contributor

@directionless directionless commented Apr 2, 2024 •
edited
Loading

Some tweaks as I debug things

  • Gather service manager logs via 2 patterns. I think the new one provides better data, but I'm not so sure I want to remove the old one
  • Don't log the full results during PublishLogs. They are too big and cause our log files to rotate way too fast.
  • Use json for things
  • set a merge strategy on go.sum to reduce conflicts

@directionless directionless changed the title Improve windowes service manager log gathering Small improvements to logging and flares Apr 2, 2024
zackattack01
zackattack01 previously approved these changes Apr 2, 2024
View reviewed changes
RebeccaMahany
RebeccaMahany previously approved these changes Apr 2, 2024
View reviewed changes
ee/debug/checkups/services_windows.go Show resolved Hide resolved
pkg/service/publish_results.go Show resolved Hide resolved
James-Pickett
James-Pickett previously approved these changes Apr 2, 2024
View reviewed changes
RebeccaMahany
RebeccaMahany previously approved these changes Apr 4, 2024
View reviewed changes
@directionless directionless added this pull request to the merge queue Apr 4, 2024
Merged via the queue into kolide:main with commit 7c49949 Apr 4, 2024
29 checks passed
@directionless directionless deleted the seph/flares branch April 4, 2024 18:04
@directionless directionless mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebeccaMahany RebeccaMahany RebeccaMahany approved these changes

@zackattack01 zackattack01 zackattack01 approved these changes

@James-Pickett James-Pickett James-Pickett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@directionless @RebeccaMahany @James-Pickett @zackattack01