Ensure desktop runner shuts down within rungroup interrupt timeout, and log shutdown completion #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RebeccaMahany
commented
Apr 2, 2024
RebeccaMahany
commented
- Increase rungroup interrupt timeout to give a little more time for desktop shutdown
- Ensure that desktop process requests respect shutdown timeout
- Log successful desktop runner interrupt
directionless
approved these changes
Apr 2, 2024
| @@ -516,7 +533,7 @@ func (r *DesktopUsersProcessesRunner) writeDefaultMenuTemplateFile() { | |||
| func (r *DesktopUsersProcessesRunner) runConsoleUserDesktop() error { | |||
| if !r.processSpawningEnabled { | |||
| // Desktop is disabled, kill any existing desktop user processes | |||
| r.killDesktopProcesses() | |||
| r.killDesktopProcesses(context.Background()) | |||
There was a problem hiding this comment.
Is this intentionally starting a new contenxt? (or should it be context.TODO())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.