Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command exec's WithUid (RunAsUser) when running as self #1682

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix command exec's WithUid (RunAsUser) when running as self #1682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ee/tables/tablehelpers/run_as_user_posix.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ func WithUid(uid string) ExecOps {
return fmt.Errorf("looking up user with uid %s: %w", uid, err)
}

if currentUser.Uid != "0" && currentUser.Uid != runningUser.Uid {
// If the current user is the user to run as, then early return to avoid needing NoSetGroups.
if currentUser.Uid == runningUser.Uid {
return nil
} else if currentUser.Uid != "0" {
return fmt.Errorf("current user %s is not root and can't start process for other user %s", currentUser.Uid, uid)
}

Expand Down
Loading