dont interact with desktop client while in standby #1700
Conversation
| @@ -531,6 +531,13 @@ func (r *DesktopUsersProcessesRunner) writeDefaultMenuTemplateFile() { | |||
| } | |||
|
|
|||
| func (r *DesktopUsersProcessesRunner) runConsoleUserDesktop() error { | |||
| if r.knapsack.InModernStandby() { | |||
There was a problem hiding this comment.
should we skip here or in the execute loop?
There was a problem hiding this comment.
Here makes sense! Looking here versus execute, I think when we're in modern standby we would still want to refresh menu data (
launcher/ee/desktop/runner/runner.go
Line 235 in 42f20a7
launcher/ee/desktop/runner/runner.go
Line 439 in 42f20a7
InModernStandby check into these individual functions makes sense to me.
There was a problem hiding this comment.
We should not tell the clients in standby.
I forget how menu refresh works, if we skip it, will we miss things, or will we pick things up?
There was a problem hiding this comment.
we will still pick up the menu changes and can still have the most updated menu available when we come out of standby
the data to update the menu comes in via the control server update
James-Pickett
changed the title
No description provided.