-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uninstall via extension / jsonrpc / grpc #1712
Merged
James-Pickett
merged 11 commits into
kolide:main
from
James-Pickett:james/uninstall-via-device-server
May 29, 2024
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ad2818a
device disable via public logs
James-Pickett 61d3b83
remove unneeded
James-Pickett 90f7346
Merge branch 'main' into james/uninstall-via-device-server
James-Pickett fcdeb54
add uninstall logic to other endpoints
James-Pickett 77a3564
clean up
James-Pickett 33ecd68
update protobuf grpc to use new property
James-Pickett 3041e79
add json rpc device disabled tests
James-Pickett 3a5de8c
unify grpc and jsonrpc client device disabled tests
James-Pickett 4e165d8
Merge branch 'main' into james/uninstall-via-device-server
James-Pickett 811cc42
Merge branch 'main' into james/uninstall-via-device-server
James-Pickett 496db8f
add returns after uninstall
James-Pickett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
package launcher | ||
|
||
//go:generate protoc --go_out=plugins=grpc:. launcher.proto | ||
//go:generate protoc --go-grpc_out=. --go_out=. launcher.proto |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hahahaha. This really points at how this method signature was limiting. This feels like a reasonable workaround, but definitely points to needing to refresh this code.