Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package-builder: add --bin_root_dir flag #1721

Merged
merged 1 commit into from
May 22, 2024

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented May 21, 2024

This PR allows the Kolide Launcher to be deployed to Fedora SilverBlue, where /usr is read-only. To build for this platform, pass --bin_root_dir=/opt to ./build/package-builder.

Without this flag, Kolide fails to install on Silverblue with:

sudo rpm-ostree install zxkx_thomas-stromberg-0ac07b_kolide-launcher.rpm                                                         
...
Resolving dependencies... done
Relabeling... done
Checking out packages... done
error: Checkout launcher-kolide-k2-1.6.2-1.x86_64: opendir(local): No such file or directory

It turns out that on Silverblue, /usr/local is a symlink to ../var/usrlocal/, which makes rpm-ostree upset with life.

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty narrow and reasonable, thank you @tstromberg

It's worth noting that making sure autoupdate works may be another ball of wax. But this is clearly a step.

@RebeccaMahany any objections?

@RebeccaMahany
Copy link
Contributor

Seems fine to me!

Setting the update_directory flag to an appropriate location (if /var/kolide-k2/<hostname>/updates isn't suitable) should solve the autoupdate issue as well.

@directionless directionless added this pull request to the merge queue May 22, 2024
@directionless directionless changed the title package-builder: add --bin_root_dir flag package-builder: add --bin_root_dir flag May 22, 2024
Merged via the queue into kolide:main with commit b7e3c0c May 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants