Universal link handler for launcher desktop #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
force-pushed
the
becca/universallink
branch
from
16ee648
to
d1d64fd
Compare
James-Pickett
approved these changes
May 30, 2024
zackattack01
approved these changes
May 30, 2024
| @@ -26,7 +26,7 @@ import ( | |||
| ) | |||
|
|
|||
| // Special Kolide Ports | |||
| var portList = []int{ | |||
| var PortList = []int{ | |||
There was a problem hiding this comment.
Downside to this, is that it's a package var, which means it could be changed. Probably more go'y to func PortList() []int but I'm not sure it really matters for our use case.
| return | ||
| } | ||
| u.slogger.Log(ctx, slog.LevelWarn, | ||
| "could not make universal link request", |
There was a problem hiding this comment.
"could not forward universal link request"
maybe?
There was a problem hiding this comment.
updated: 3ad09a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a handler for universal links, forwarding them to root launcher's localserver.
Requires: kolide/systray#5