optimize windows service startup #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
approved these changes
Jul 26, 2024
James-Pickett
approved these changes
Jul 26, 2024
directionless
approved these changes
Jul 27, 2024
|
regarding the spans - I will check that out next! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments for additional technical context
We are seeing issues with windows devices timing out before launcher is able to start in certain environments. This typically coincides with significant resource contention/high activity during boot up. One bit of logic that stood out as possibly dragging things out is our registry and service manager interactions (to perform runtime service configuration).
Moving these checks into the Execute function, after our Running status update should help to make startup faster, or at least more responsive to service control manager