[Chrome IndexedDB] Fix header processing #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
approved these changes
Jul 31, 2024
RebeccaMahany
added
breaking-change
|
(I added and removed a bunch of labels to this PR while working on #1815 to test it, but I am done now and it is correctly labeled) |
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't adequately accounting for the header structure before. This appears to be correct now -- needed to add a constraint that the header ENDS with
<version tag, version, object tag>, instead of terminating processing the header as soon as we see<object tag>(because that may occur before the end of the header and should just be ignored).