support preprod dual install #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackattack01
force-pushed
the
zack/support_preprod_dual_install
branch
from
dc77ec7
to
2289b74
Compare
ee/debug/shipper/shipper.go
Outdated
Comment on lines
271
to
282
| // TODO this will need to respect the identifier when determining the secret file location for dual-launcher installations | ||
| b, err := os.ReadFile(launcher.DefaultPath(launcher.SecretFile)) |
There was a problem hiding this comment.
oooo.... This one we might need to fix. Can we shift it to using the secret in something configured instead of DefaultPath?
There was a problem hiding this comment.
I think we can make this fallback to reading from knapsack.EnrollSecretPath() first and that will fix this when running in situ at least. fixing for CLI triggered flares looks tougher
… package and integrate with windows svc
zackattack01
force-pushed
the
zack/support_preprod_dual_install
branch
from
4cd67c9
to
978c39a
Compare
directionless
previously approved these changes
Aug 16, 2024
| // by multiple installations. This is less of an issue when the flare is run in situ, but should be noted because | ||
| // we may need to pay closer attention to the results. When run standalone without a config argument passed, it would be | ||
| // possible for flare to default to reading the directories for the wrong installation | ||
| func noteMultipleInstallations(z *zip.Writer) { |
There was a problem hiding this comment.
Feels weird not to push this through the normal checkup interface. But okay...
zackattack01
dismissed stale reviews from directionless and James-Pickett
via
0002586
directionless
approved these changes
Aug 16, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to support multiple installations: