windows arm64 fixes, upgrade winio and thrift #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
changed the title
James-Pickett
changed the title
James-Pickett
commented
Sep 10, 2024
ee/wmi/wmi.go
Outdated
| // calling service.Release() and the serviceRaw.Clear() (or the reverse) causes | ||
| // a panic on arm64 (Exception 0xc0000005: Access Violation). The hunch is that on arm64 | ||
| // one clears the memory of the other. | ||
| defer service.Release() |
There was a problem hiding this comment.
I'm making the assumption here that the call to serviceRaw.Clear() that is defered above will release this as well because we get an access violation if both serviceRaw.Clear() and service.Release() get called (regardless of order)
There was a problem hiding this comment.
Hrm. I wonder if something isn't doing what we think in service := serviceRaw.ToIDispatch()
All this stuff is deep in unsafe pointer land
There was a problem hiding this comment.
But it seems like we should be able to make a pretty small test case and post it as an issue.
Though... go-ole/go-ole#255
directionless
previously approved these changes
Sep 11, 2024
James-Pickett
changed the title
RebeccaMahany
approved these changes
Sep 11, 2024
directionless
approved these changes
Sep 11, 2024
RebeccaMahany
added a commit
to RebeccaMahany/launcher
that referenced
this pull request
Sep 13, 2024
desktop triggers Windows Hello Fix timeout, small refactor Tidy up names, add documentation Retrieve key credential status Retrieve pubkey Get attestation windows arm64 fixes, upgrade winio and thrift (kolide#1858) Fix `autoupdate_managed` table value for MacOS 15 (kolide#1862) james/remove wmi unneeded releases (kolide#1863) Check windows service manager settings prior to setting them (kolide#1859) Co-authored-by: Michael <60191460+lurky@users.noreply.github.com> Co-authored-by: seph <seph@kolide.co> Co-authored-by: Rebecca Mahany-Horton <rebeccamahany@gmail.com> Update function signature Move to ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.