-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge insecureGRPC and insecureJSONRPC #435
Conversation
Create insecureTransport as a unification of insecureGRPC and insecureJSONRPC. These options are meaningless to split, and this way has less to get tangled up with.
Have you considered not passing a second "insecure" option to NewJSONRPC? The reason gRPC has two is because it's possible to use tls(with a insecure cert) or drop tls entirely. Currently for JSONRPC you're passing two "insecure" flags. one manages TLS. What does the other do? |
For good or ill, the jsonrpc transport intends to follow the same model. You can connect to http or https, and you can verify or not verify the certs. I've certainly considered merging the two options, or renaming |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I think we should either mention it explicitly in a change log or just check & error if the insecure_grpc
flag is passed.
@blaedj Normal flag parsing will spit an error back for unknown flags. I don't want to extend that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thats true,
Create insecureTransport as a unification of insecureGRPC and insecureJSONRPC.
These options are meaningless to split, and this way has less to get tangled up with.