Postinstall script to generate an info file #530
Conversation
This moves the postinstall templates to go-asset, As these get more complicated, it's simpler to work with
I can't get the bash quoting right to pass spaces through the basename and heredoc. Instead, set a variable, and just use that.
directionless
force-pushed
the
seph/postinstall-scripts
branch
from
b2852c3
to
8ff9cdc
Compare
|
I've manually tested this on Mojave and Catalina. Also on docker images for centos and ubuntu. These are a bit less precise -- they don't have systemd in place, so while the conf file is generated, the overall install fails. |
Does this mean that this PR will break installation on centos/ubuntu? Or just that installing in the docker container breaks, but that's fine because we use an image rather than installing into docker containers ? |
|
The existing packages won't work on minimal docker installs. This is because the postinst scripts try to invoke systemd. The overall install has always been broken there. (possibly we can make this more clever, but I don't want to try to get that logic into this PR) AFAICT this is no change from status quo |
|
Ok cool, that makes sense. I agree, the issue w/docker is not in-scope for this PR |
We often want to understand what happened during installation. So the postinstall script should drop a config file onto disk with some basic info.
This is expected to be json, though on osx we additionally keep it as a plist.
To make this simpler, the postinstall templates have been extracted into the asset generation flow.