Support architectures in the build/release side #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
force-pushed
the
seph/universal-builds
branch
from
57857c6
to
1d5b1a8
Compare
blaedj
reviewed
Dec 14, 2020
blaedj
reviewed
Dec 14, 2020
| launchas-osqueryi-tables: table.ext | ||
| sudo launchctl asuser 0 osqueryd -S --allow-unsafe --verbose --extension ./build/darwin/tables.ext | ||
| # Actual release targets. Because of the m1 cgo cross stuff, this requires explicit go paths | ||
| rel-amd64: CROSSGOPATH = /Users/seph/go1.15.6.darwin-amd64/bin/go |
There was a problem hiding this comment.
Could this be ~/go1.14.6.darwin-amd64/bin/go or does the path need to be that specific?
There was a problem hiding this comment.
It could probably use ~. Once there's a real m1 release, I expect we'll drop these into nicer paths anyhow
blaedj
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build/release process to support creating darwin universal binaries. This requires building on an m1 machine, with go installed at the specified paths.
To make this a bit smoother, it also updates a handful of the abstractions across our build tools.
This will likely get smoother as the m1 ecosystem evolves.