Set context timeouts on all exec functions #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaedj
reviewed
Dec 21, 2020
| @@ -12,7 +12,7 @@ import ( | |||
| ) | |||
|
|
|||
| func mdfind(args ...string) ([]string, error) { | |||
| ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) | |||
| ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) | |||
There was a problem hiding this comment.
we see a lot of timeouts for mdfind, will there significant perf impacts to devices by 10x-ing this timeout? Does mdfind use significant CPU? ( it seems like this is a potential CPU hotspot depending on the query)
There was a problem hiding this comment.
No clue. I just upped the numbers.
There was a problem hiding this comment.
Fair enough. I don't think we have significant safety nets for other performance sensitive areas, so this is probably in line with current art.
blaedj
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewing the places we call exec, and attempting to get timeouts on all of them