Add a startup delay to the autoupdater, to avoid interfering with critical work #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaedj
reviewed
Dec 28, 2020
Co-authored-by: blaedj <blaedj@users.noreply.github.com>
blaedj
approved these changes
Jan 21, 2021
Yes, this delays applies on eery launcher start. Where do you think we should say that? I think it's implied by the option help text. |
I just did, above 😄 the option help text is fine as-is, I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launcher first enrolls with a server, it often begins fetching key data. However, the autoupdater also starts. And if there's a pending update, this has the effect of pre-empting that early data.
This introduces a simple option to delay the autoupdater to allow key data to come in first. This option defaults to an hour.