Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output bug in kolide_profiles #698

Merged
merged 4 commits into from
Jan 12, 2021

Conversation

directionless
Copy link
Contributor

Apple's profiles command does not correctly output stdout in one very narrow case. Work around this by writing output to a temp file.

Additionally, restrict the commands allowed on profiles to read only commands. This is enforced by a new option to the GetConstraints helper.

Copy link
Contributor

@blaedj blaedj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested out locally and can confirm that it produces output as expected for queries that do not return values on commits prior to this.

I did have one question on the tests

@directionless directionless merged commit 4fc7c8d into kolide:master Jan 12, 2021
@directionless directionless deleted the seph/profiler-stdout branch January 12, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants