-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wifi-ish table for linux #702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit: - uses the --pretty flag to nmcli, because that causes each wifi network's properties to be separated by a line of dashes
This commit: - implements a new strategy for detecting separators between new records, without relying on the `--pretty` flag.
This commit: - adds a new KeyValue DataSourceType, that assumes a simple string separator between key and value in a single line - adds a new 'StringDelmitedUnseparatedFunc' to be used as the dataFunc for tables with the KeyValue datasource type - adds a funcitonal option for setting the separator string for KeyValue tables (the default is ":") - updates the TablePluginExec function to accept functional options parameters - including adding the ExecTableOpt type for the function options - updates platform_tables_linux to define kolide_nmcli as a TablePluginExec call
blaedj
force-pushed
the
nmcli-networks
branch
from
February 3, 2021 15:35
0378080
to
070c5fd
Compare
blaedj
force-pushed
the
nmcli-networks
branch
from
February 3, 2021 15:36
070c5fd
to
2a4226e
Compare
directionless
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this. Some small scale things
directionless
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
record-splitting based on the idea that if we see a key 'again', we
should start a new record, instead of over-writing the key.
KeyValue
data source type to dataflattentabledataflattentable.TablePluginExec
callNote that this table will only work if nmcli is installed, so it's not a true
solution for all linux installations.