Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PUT updates if needed annotations missing #130

Merged
merged 1 commit into from
May 31, 2019
Merged

PUT updates if needed annotations missing #130

merged 1 commit into from
May 31, 2019

Conversation

jnummelin
Copy link
Contributor

If user has removed al k8s-client managed annotations, the stack apply failed with:

Error: undefined method `[]' for nil:NilClass
    /__enclose_io_memfs__/lib/ruby/gems/2.5.0/gems/k8s-client-0.8.3/lib/k8s/stack.rb:104:in `block in apply'
    /__enclose_io_memfs__/lib/ruby/gems/2.5.0/gems/k8s-client-0.8.3/lib/k8s/stack.rb:100:in `map'
    /__enclose_io_memfs__/lib/ruby/gems/2.5.0/gems/k8s-client-0.8.3/lib/k8s/stack.rb:100:in `apply'

jakolehm
jakolehm approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm
Copy link
Contributor

#108 seems similar, we can probably close it after this is merged.

@jakolehm jakolehm added the bug Something isn't working label May 31, 2019
@jakolehm jakolehm merged commit 4cd1811 into master May 31, 2019
@jakolehm jakolehm deleted the fix/missing-annotations branch May 31, 2019 07:02
This was referenced May 31, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnummelin @jakolehm