Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make from_json parse JSON #70

Merged
merged 1 commit into from
Dec 29, 2018
Merged

Make from_json parse JSON #70

merged 1 commit into from
Dec 29, 2018

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 14, 2018

The from_json methods misleadingly do not parse JSON and are equivalent to .new

This PR makes them parse JSON.

@kke kke added bug Something isn't working enhancement New feature or request labels Dec 14, 2018
@jnummelin jnummelin merged commit 94f6e03 into master Dec 29, 2018
@jnummelin jnummelin deleted the fix/from_json_parses_json branch December 29, 2018 06:51
@jakolehm jakolehm mentioned this pull request Jan 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kke @jakolehm @jnummelin