Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try uncached api_resources before raising K8s::Error::UndefinedResource #83

Merged
merged 3 commits into from
Jan 2, 2019

Conversation

kke
Copy link
Contributor

@kke kke commented Jan 2, 2019

Fixes #82
Fixes kontena/pharos-cluster#939 (it already retries but currently will always retry until retry limit is reached because the cache isn't cleared between retries)

@kke kke added the enhancement New feature or request label Jan 2, 2019
@kke kke closed this Jan 2, 2019
@kke kke reopened this Jan 2, 2019
@kke kke changed the title Optionally clear resource cache on UndefinedResource exceptions Try uncached api_resources before raising K8s::Error::UndefinedResource Jan 2, 2019
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit c1c3a53 into master Jan 2, 2019
@jakolehm jakolehm deleted the feature/clear_cache_on_exception branch January 2, 2019 10:46
@jakolehm jakolehm mentioned this pull request Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants