Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate connection when response_block is given #93

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Use separate connection when response_block is given #93

merged 1 commit into from
Mar 12, 2019

Conversation

jakolehm
Copy link
Contributor

@jakolehm jakolehm commented Jan 9, 2019

Maybe fixes #77 .

kke
kke approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@kke kke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't hurt even if it doesn't fix the #77

@kke
Copy link
Contributor

kke commented Jan 9, 2019

transport.excon is public so the user in theory could have done something through it and it wouldn't be reflected on the secondary client, but that's a bit far fetched.

Maybe make the excon private in the transport anyway, it's supposed to mask it.

@jakolehm jakolehm added the bug Something isn't working label Mar 12, 2019
@jakolehm jakolehm merged commit f5865a4 into master Mar 12, 2019
@jakolehm jakolehm deleted the fix/issue-77 branch March 12, 2019 06:23
@jakolehm jakolehm mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kke kke kke approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

excon malformed headers when doing resource update inside of watch
2 participants
@jakolehm @kke