-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repository): Add Custom Root CA option for S3 #2845
Conversation
example: ```bash kopia repository connect s3 \ --access-key the-access-key \ --secret-access-key the-secret-key \ --bucket my-backup-bucket \ --endpoint localhost:9000 \ --rootca=$(cat public.crt|base64 -w0) ```
* Lower case JSON option * Handle file as well as inline * Add env variable * Standardize options names
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 75.27% 75.31% +0.04%
==========================================
Files 457 457
Lines 35901 35923 +22
==========================================
+ Hits 27024 27057 +33
+ Misses 6984 6976 -8
+ Partials 1893 1890 -3
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@jkowalski Do you have suggestions for testing this better? CLI tests are hard. |
I've something almost ready :) |
I think this one should start to look nice :) |
Note for myself, don't rely on platform message :)
Closes #1443
example:
kopia repository connect s3 \ --access-key the-access-key \ --secret-access-key the-secret-key \ --bucket my-backup-bucket \ --endpoint localhost:9000 \ --root-ca-pem-base64=$(cat public.crt | base64 -w0)
ROOT_CA_PEM_BASE64=$(cat public.crt | base64 -w0) kopia repository connect s3 \ --access-key the-access-key \ --secret-access-key the-secret-key \ --bucket my-backup-bucket \ --endpoint localhost:9000