Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate output regarding backport result (#211) #317

Merged
merged 3 commits into from
Jan 17, 2023

Conversation

alxgrk
Copy link
Contributor

@alxgrk alxgrk commented Jan 15, 2023

Referring to #211: write to Github Actions Output whether all backports were successful and break down that information by all extracted backport targets.

Copy link
Owner

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 This is a really cool contribution @alxgrk 🙇 Thanks so much for this!

👍 I've successfully tested it with my E2E test project (backport-action-test), and it works great!

To make it work, I needed to build a new distribution. I did this by locally running npm ci && npm run all in the root of this project. Doing so automatically is something I want to improve in the near future (see #313).

🔧 We should still document this in the README, but this can be done in a new pull request. I'll open an issue for it. ❓ Would you be willing to contribute that as well?

@korthout korthout merged commit 9797e06 into korthout:main Jan 17, 2023
@korthout korthout mentioned this pull request Jan 17, 2023
@alxgrk
Copy link
Contributor Author

alxgrk commented Jan 19, 2023

@korthout , glad I could contribute & your tests were successful. 🙂

Just to be sure, you published a new version, which will be consumed automatically, if no version is specified in the workflow using it? Because I don't see any new git tag or similar...

Regarding #319 , I will try to pick it up asap.

@korthout
Copy link
Owner

korthout commented Jan 19, 2023

Because I don't see any new git tag or similar...

@alxgrk I did not yet release a new version. I'd like to wait until #319 is completed.

I was considering spending some time on #314 this afternoon to see if I could release both new features as v1.1.0 as I'll be out of the office next week.

If you'd like to use your new version immediately, you could switch to korthout/backport-action@main.

EDIT: To be fair, it might be better if I pick up #319 just to get it out quickly. Is that okay for you?

@alxgrk
Copy link
Contributor Author

alxgrk commented Jan 19, 2023

Sounds good, please go ahead. 👍

@korthout korthout mentioned this pull request Jan 20, 2023
@korthout
Copy link
Owner

korthout commented Jan 20, 2023

@alxgrk I sadly did not find the time to do all the work I wanted. So I ended up just adding the outputs to the README.

Your feature is now available in v1.1.0, v1.1, v1, and v1.next-preview. See release Backport-action v1.1.0

@alxgrk
Copy link
Contributor Author

alxgrk commented Jan 20, 2023

I feel you 😅 thank you very much for publishing it anyways 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants