Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateRecommendation API. #825

Merged
merged 17 commits into from
Aug 12, 2023
Merged

Conversation

msvinaykumar
Copy link
Contributor

@msvinaykumar msvinaykumar commented May 18, 2023

No description provided.

@msvinaykumar msvinaykumar added the enhancement New feature or request label May 18, 2023
@msvinaykumar msvinaykumar added this to the Kruize 0.0.15_rm Release milestone May 18, 2023
@msvinaykumar msvinaykumar self-assigned this May 18, 2023
@msvinaykumar msvinaykumar added API Requires API Changes and removed enhancement New feature or request labels May 23, 2023
@msvinaykumar msvinaykumar force-pushed the updateRecommendation branch 2 times, most recently from 2988997 to 80c0f0b Compare May 23, 2023 12:26
@msvinaykumar msvinaykumar changed the title In progress code checked in for updateRecommendation API. updateRecommendation API. Jun 5, 2023
@msvinaykumar msvinaykumar force-pushed the updateRecommendation branch 2 times, most recently from 275001d to 8497740 Compare June 6, 2023 10:23
@msvinaykumar msvinaykumar requested review from khansaad, dinogun and bharathappali and removed request for khansaad and dinogun June 13, 2023 12:43
@msvinaykumar msvinaykumar force-pushed the updateRecommendation branch 2 times, most recently from 06733ab to 67ed47f Compare July 20, 2023 11:06
@msvinaykumar msvinaykumar force-pushed the updateRecommendation branch 5 times, most recently from e877df3 to 80b7565 Compare July 21, 2023 07:37
@dinogun
Copy link
Contributor

dinogun commented Aug 11, 2023

@msvinaykumar have you tested if the recommendation changes when old result data is added after a recommendation is produced

khansaad and others added 15 commits August 11, 2023 12:23
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Copy link
Contributor Author

msvinaykumar commented Aug 11, 2023

@msvinaykumar have you tested if the recommendation changes when old result data is added after a recommendation is produced

If there are any changes in the data, the recommendation, even if it has already been generated for the specified date using the updateRecommendation API, will get updated.

@dinogun
Copy link
Contributor

dinogun commented Aug 11, 2023

@msvinaykumar there seems to be a build failure, can you PTAL

Error: ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project autotune: Compilation failure
Error: ERROR] /home/autotune/src/autotune/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java:[28,8] com.autotune.database.dao.ExperimentDAOImpl is not abstract and does not override abstract method isDataExistsInResults(java.lang.String,java.sql.Timestamp) in com.autotune.database.dao.ExperimentDAO

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Copy link
Contributor Author

@msvinaykumar there seems to be a build failure, can you PTAL

Error: ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default-compile) on project autotune: Compilation failure
Error: ERROR] /home/autotune/src/autotune/src/main/java/com/autotune/database/dao/ExperimentDAOImpl.java:[28,8] com.autotune.database.dao.ExperimentDAOImpl is not abstract and does not override abstract method isDataExistsInResults(java.lang.String,java.sql.Timestamp) in com.autotune.database.dao.ExperimentDAO

fixed

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun
Copy link
Contributor

dinogun commented Aug 12, 2023

build_crc PR job is expected to fail until #836 gets merged

@dinogun dinogun merged commit 2ae36cd into kruize:mvp_demo Aug 12, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Requires API Changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New API 'UpdateRecommendations' to support non-chronological order of data
5 participants