-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updateRecommendation API. #825
Conversation
2988997
to
80c0f0b
Compare
a2d5f90
to
aa1074d
Compare
275001d
to
8497740
Compare
2bf2dfe
to
fa98657
Compare
fa98657
to
61af234
Compare
06733ab
to
67ed47f
Compare
e877df3
to
80b7565
Compare
@msvinaykumar have you tested if the recommendation changes when old result data is added after a recommendation is produced |
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: saakhan <saakhan@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
4bac361
to
c5b5c57
Compare
If there are any changes in the data, the recommendation, even if it has already been generated for the specified date using the updateRecommendation API, will get updated. |
@msvinaykumar there seems to be a build failure, can you PTAL
|
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
fixed |
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
build_crc PR job is expected to fail until #836 gets merged |
No description provided.