Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get data to generate recommendation #855

Merged
merged 32 commits into from
Aug 14, 2023
Merged

Get data to generate recommendation #855

merged 32 commits into from
Aug 14, 2023

Conversation

msvinaykumar
Copy link
Contributor

Earlier results data are retrieved outside performance profile util
now logic is moved into Perf profile.

@msvinaykumar msvinaykumar self-assigned this Jun 12, 2023
@msvinaykumar msvinaykumar added the API Requires API Changes label Jun 12, 2023
@msvinaykumar msvinaykumar linked an issue Jun 12, 2023 that may be closed by this pull request
New API 'UpdateRecommendations' to support non-chronological order of data #816
Closed
@chandrams
Copy link
Contributor

@msvinaykumar - Are these changes internal? Does these changes affect the API behavior or externals in any way?

@msvinaykumar msvinaykumar linked an issue Jul 25, 2023 that may be closed by this pull request
[Scalability] - Using UpdateRecomm API optimize code to handle horizontal scaling of pods #815
Closed
@msvinaykumar msvinaykumar force-pushed the getDataToGenRecommendation branch 2 times, most recently from e72378b to 5138166 Compare August 11, 2023 08:31
@msvinaykumar
In progress code checked in for updateRecommendation API.
1db668c 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
0555789 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
5a0a581 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Taking care of duplicate entry to recommendation table
70441c5 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
fixed build error
56c62c9 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
reloved conflicts
6a8d6eb 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolving conflicts
4c2cc95 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateResults API optimized.
bee777e 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
084a5ce 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolving conflicts
9971435 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
enabled version column for results and recommendations
e20fb35 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
incorporated review comments
93f5636 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
61782e3 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Moved logic to select results into perfProfiles.
503eb41 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
ef9c348 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
df3fd60 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
f6d49b6 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Merging confilts
8fce008 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
resolved conflicts
ee34f16 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
12266c5 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
c0df4f3 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
ea021b2 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
5db6508 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Merging confilts
cebfc43 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
In progress code checked in for updateRecommendation API.
e689250 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
UpdateRecommendation API E2E working code is ready.
fd63f51 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Added exception conditions.
b30581d 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
To restrict the number of rows in the result set, the Load results op…
4e6f5a1 
…eration involves locating the appropriate method and configuring the desired limitation. It's important to note that in order for the Limit rows feature to function correctly, the CreateExperiment API must adhere strictly to the trail settings' measurement duration and should not allow arbitrary values

Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Merging confilts
ac50e5f 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Removed end_date from mandatory feilds
bd5db05 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Resolved conflicts
455e7c6 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
@msvinaykumar
Resolved conflicts
780f615 
Signed-off-by: msvinaykumar <vinakuma@redhat.com>
dinogun
dinogun reviewed Aug 14, 2023
View reviewed changes
...lyzer/performanceProfiles/PerformanceProfileInterface/ResourceOptimizationOpenshiftImpl.java
int limitRows = (int) ((
KruizeConstants.RecommendationEngineConstants.DurationBasedEngine.DurationAmount.LONG_TERM_DURATION_DAYS *
KruizeConstants.DateFormats.MINUTES_FOR_DAY)
/ kruizeObject.getTrial_settings().getMeasurement_durationMinutes_inDouble());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be limitRows = LONG_TERM_MINS / durationMins + 1?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I see that it is existing code moved inside the generateRecommendation method now

dinogun
dinogun approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@dinogun dinogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun dinogun merged commit 18ca637 into kruize:mvp_demo Aug 14, 2023
1 of 2 checks passed
@msvinaykumar msvinaykumar mentioned this pull request Aug 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinogun dinogun dinogun approved these changes

@bharathappali bharathappali Awaiting requested review from bharathappali

@khansaad khansaad Awaiting requested review from khansaad

Assignees

@msvinaykumar msvinaykumar

Labels
API Requires API Changes
Projects
Monitoring
Status: Done
Milestone
Kruize 0.0.18_rm Release
4 participants
@msvinaykumar @chandrams @dinogun @rbadagandi1